Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add databricks_credential resource #4219

Merged
merged 27 commits into from
Nov 28, 2024
Merged

[Feature] Add databricks_credential resource #4219

merged 27 commits into from
Nov 28, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Nov 13, 2024 •
edited
Loading

Changes

Resolves #4214

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners November 13, 2024 08:31
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team November 13, 2024 08:31
alexott
alexott reviewed Nov 13, 2024
View reviewed changes
docs/resources/credential.md Outdated Show resolved Hide resolved
docs/resources/grant.md Show resolved Hide resolved
docs/resources/credential.md Show resolved Hide resolved
@alexott
Copy link
Contributor

alexott commented Nov 13, 2024

Should we add something regarding the IAM role requirements? https://docs.databricks.com/en/connect/unity-catalog/cloud-services/service-credentials.html#step-1-create-an-iam-role

alexott
alexott reviewed Nov 14, 2024
View reviewed changes
catalog/resource_credential.go Show resolved Hide resolved
docs/resources/credential.md Outdated Show resolved Hide resolved
docs/resources/credential.md Show resolved Hide resolved
docs/resources/credential.md Show resolved Hide resolved
docs/resources/grant.md Show resolved Hide resolved
@nkvuong @farrucosanjurjo-db
Apply suggestions from code review
85b0f7d 
Co-authored-by: Farruco Sanjurjo <farruco.sanjurjo@databricks.com>
alexott
alexott approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small comment

catalog/resource_credential.go Outdated Show resolved Hide resolved
@alexott @madtrick
Update docs/resources/credential.md
8bad26e 
Co-authored-by: Farruco Sanjurjo <madtrick@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4219
  • Commit SHA: 8bad26e95f31bbdf720dfea52505ee24ec53b458

Checks will be approved automatically on success.

@alexott alexott enabled auto-merge November 28, 2024 09:16
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12065885126

@alexott alexott added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit f119680 Nov 28, 2024
12 checks passed
@alexott alexott deleted the feature/credential branch November 28, 2024 10:20
tanmay-db added a commit that referenced this pull request Dec 10, 2024
@tanmay-db
[Release] Release v1.60.0
2e9da14 
### New Features and Improvements

 * Add `databricks_credential` resource ([#4219](#4219)).
 * Allow to filter jobs by name in `databricks_jobs` data source ([#3395](#3395)).

### Bug Fixes

 * Add client side validation for `volume_type` ([#4289](#4289)).
 * Add missing H2 header in `mws_network_connectivity_configs.md` and optimization in `data_mws_network_connectivity_configs` ([#4256](#4256)).
 * Forced send `auto_stop_mins` for `databricks_sql_endpoint` resource ([#4265](#4265)).
 * Handle deleted cluster gracefully ([#4280](#4280)).
 * Remove config drift if Azure SP is used in `databricks_credential` ([#4294](#4294)).
 * Use correct domain for Azure Gov and China ([#4274](#4274)).
 * don't start cluster if `warehouse_id` is specified for `databricks_sql_table` resource ([#4259](#4259)).

### Documentation

 * Document import support for `databricks_notification_destination` ([#4276](#4276)).
 * Update documentation for importing some MWS resources ([#4281](#4281)).
 * Update mws_log_delivery.md to add time_sleep ([#4258](#4258)).

### Internal Changes

 * Add ConvertToAttribute() to convert blocks in a resource/data source schema to attributes ([#4284](#4284)).
 * Bump Go SDK and generate TF structs ([#4300](#4300)).
 * Generate effective fields based of isServiceProposedIfEmpty ([#4282](#4282)).
 * Ignore Databricks Go SDK updates by dependabot ([#4253](#4253)).
 * Move TFSDK model template to universe ([#4303](#4303)).
 * Remove unused configuration from blocks ([#4283](#4283)).
 * Use isServiceProposedIfEmpty annotations for effective fields ([#4270](#4270)).
 * Use tf_v1 genkit mode ([#4278](#4278)).

### Dependency Updates

 * Bump github.com/stretchr/testify from 1.9.0 to 1.10.0 ([#4269](#4269)).
 * Bump github.com/zclconf/go-cty from 1.15.0 to 1.15.1 ([#4273](#4273)).

### Exporter

 * Fix generation of references to users for user directories ([#4297](#4297)).
 * better handling of online tables/vsis in listing ([#4288](#4288)).
@tanmay-db tanmay-db mentioned this pull request Dec 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2024
@tanmay-db
[Release] Release v1.60.0 (#4306)
89a7a33 
### New Features and Improvements

* Add `databricks_credential` resource
([#4219](#4219)).
* Allow to filter jobs by name in `databricks_jobs` data source
([#3395](#3395)).


### Bug Fixes

* Add client side validation for `volume_type`
([#4289](#4289)).
* Add missing H2 header in `mws_network_connectivity_configs.md` and
optimization in `data_mws_network_connectivity_configs`
([#4256](#4256)).
* Forced send `auto_stop_mins` for `databricks_sql_endpoint` resource
([#4265](#4265)).
* Handle deleted cluster gracefully
([#4280](#4280)).
* Remove config drift if Azure SP is used in `databricks_credential`
([#4294](#4294)).
* Use correct domain for Azure Gov and China
([#4274](#4274)).
* don't start cluster if `warehouse_id` is specified for
`databricks_sql_table` resource
([#4259](#4259)).


### Documentation

* Document import support for `databricks_notification_destination`
([#4276](#4276)).
* Update documentation for importing some MWS resources
([#4281](#4281)).
* Update mws_log_delivery.md to add time_sleep
([#4258](#4258)).


### Internal Changes

* Add ConvertToAttribute() to convert blocks in a resource/data source
schema to attributes
([#4284](#4284)).
* Bump Go SDK and generate TF structs
([#4300](#4300)).
* Generate effective fields based of isServiceProposedIfEmpty
([#4282](#4282)).
* Ignore Databricks Go SDK updates by dependabot
([#4253](#4253)).
* Move TFSDK model template to universe
([#4303](#4303)).
* Remove unused configuration from blocks
([#4283](#4283)).
* Use isServiceProposedIfEmpty annotations for effective fields
([#4270](#4270)).
* Use tf_v1 genkit mode
([#4278](#4278)).


### Dependency Updates

* Bump github.com/stretchr/testify from 1.9.0 to 1.10.0
([#4269](#4269)).
* Bump github.com/zclconf/go-cty from 1.15.0 to 1.15.1
([#4273](#4273)).


### Exporter

* Fix generation of references to users for user directories
([#4297](#4297)).
* better handling of online tables/vsis in listing
([#4288](#4288)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farrucosanjurjo-db farrucosanjurjo-db farrucosanjurjo-db approved these changes

@madtrick madtrick madtrick left review comments

@alexott alexott alexott approved these changes

@hectorcast-db hectorcast-db Awaiting requested review from hectorcast-db hectorcast-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for UC Credentials
5 participants
@nkvuong @alexott @eng-dev-ecosystem-bot @madtrick @farrucosanjurjo-db