Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Added TF Plugin Framework checkbox item to PR template and removed checkbox for integration tests passing #4227

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Nov 14, 2024

Changes

To facilitate migration to plugin framework :-)

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners November 14, 2024 11:03
@alexott alexott requested review from hectorcast-db and removed request for a team November 14, 2024 11:03
@alexott alexott changed the title [Internal] Added TF Plugin Framework checkbox item to PR template [Internal] Added TF Plugin Framework checkbox item to PR template and remove checkbox for integration tests passing Nov 20, 2024
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4227
  • Commit SHA: f1e6ed01391c7128bf6a115dd4ebea30e60ac326

Checks will be approved automatically on success.

@alexott alexott changed the title [Internal] Added TF Plugin Framework checkbox item to PR template and remove checkbox for integration tests passing [Internal] Added TF Plugin Framework checkbox item to PR template and removedcheckbox for integration tests passing Nov 20, 2024
@alexott alexott changed the title [Internal] Added TF Plugin Framework checkbox item to PR template and removedcheckbox for integration tests passing [Internal] Added TF Plugin Framework checkbox item to PR template and removed checkbox for integration tests passing Nov 20, 2024
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11933845303

@mgyucht mgyucht added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e48fa77 Dec 12, 2024
18 checks passed
@mgyucht mgyucht deleted the internal/update-pr-template branch December 12, 2024 14:11
mgyucht added a commit that referenced this pull request Dec 12, 2024
### New Features and Improvements

 * Add `databricks_app` resource and data source ([#4099](#4099)).

### Documentation

 * Add a warning that attribute should be used in `databricks_permissions` for `databricks_vector_search_endpoint` ([#4312](#4312)).

### Internal Changes

 * Added TF Plugin Framework checkbox item to PR template and removed checkbox for integration tests passing ([#4227](#4227)).
 * Expose several integration test helpers for use in plugin framework integration tests ([#4310](#4310)).
 * Fix ReadOnly() for ListNestedAttribute and Validators for ListNestedBlock ([#4313](#4313)).
 * Panic if the provided path is invalid ([#4309](#4309)).
 * Simplify `databricks_storage_credential` code ([#4301](#4301)).
 * Use Attributes by default for List Objects ([#4315](#4315)).
 * Use Plugin Framework types internally in generated TF SDK structures ([#4291](#4291)).
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
### New Features and Improvements

* Add `databricks_app` resource and data source
([#4099](#4099)).


### Documentation

* Add a warning that attribute should be used in
`databricks_permissions` for `databricks_vector_search_endpoint`
([#4312](#4312)).


### Internal Changes

* Added TF Plugin Framework checkbox item to PR template and removed
checkbox for integration tests passing
([#4227](#4227)).
* Expose several integration test helpers for use in plugin framework
integration tests
([#4310](#4310)).
* Fix ReadOnly() for ListNestedAttribute and Validators for
ListNestedBlock
([#4313](#4313)).
* Panic if the provided path is invalid
([#4309](#4309)).
* Simplify `databricks_storage_credential` code
([#4301](#4301)).
* Use Attributes by default for List Objects
([#4315](#4315)).
* Use Plugin Framework types internally in generated TF SDK structures
([#4291](#4291)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants