Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter] Refactor jobs implementation to use only Go SDK #4380

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[Exporter] Refactor jobs implementation to use only Go SDK #4380

merged 1 commit into from
Jan 16, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 8, 2025 •
edited
Loading

Changes

Resolves #4341

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners January 8, 2025 09:06
@alexott alexott requested review from parthban-db and removed request for a team January 8, 2025 09:06
@alexott alexott temporarily deployed to test-trigger-is January 8, 2025 09:06 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 8, 2025 09:08 — with GitHub Actions Inactive
@alexott alexott added the exporter TF configuration generator label Jan 10, 2025
@tanmay-db tanmay-db added this pull request to the merge queue Jan 15, 2025
@tanmay-db tanmay-db removed this pull request from the merge queue due to a manual request Jan 15, 2025
@alexott alexott force-pushed the exporter/jobs-refactoring branch from 15e2160 to 88fe9ba Compare January 15, 2025 15:42
@alexott alexott temporarily deployed to test-trigger-is January 15, 2025 15:42 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 15, 2025 15:42 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4380
  • Commit SHA: 88fe9ba17632df75a783a84858f2341f5b625b29

Checks will be approved automatically on success.

@alexott alexott enabled auto-merge January 16, 2025 09:26
@alexott alexott added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit d39ac4a Jan 16, 2025
14 checks passed
@alexott alexott deleted the exporter/jobs-refactoring branch January 16, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmay-db tanmay-db tanmay-db approved these changes

@parthban-db parthban-db Awaiting requested review from parthban-db parthban-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Exporter] Reimplement jobs listing using Go SDK
2 participants
@alexott @tanmay-db