Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add note about use of azurerm_databricks for enhanced security settings #4393

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[Doc] Add note about use of azurerm_databricks for enhanced security settings #4393

merged 2 commits into from
Jan 13, 2025
+7 −0

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 13, 2025

Changes

On Azure, enhanced security compliance and monitoring settings need to be enabled using the azurerm_databricks resource from the azurerm provider.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners January 13, 2025 07:36
@alexott alexott requested review from mgyucht and removed request for a team January 13, 2025 07:36
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 07:36 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 07:38 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 09:03 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 09:04 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 09:16 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 09:18 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 09:21 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 09:22 — with GitHub Actions Inactive
@alexott alexott force-pushed the doc/azure-csp-warnings branch from a2872b6 to 9d52e9b Compare January 13, 2025 15:07
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 15:07 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 15:08 — with GitHub Actions Inactive
mgyucht
mgyucht approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what you mean?

docs/resources/automatic_cluster_update_setting.md Outdated Show resolved Hide resolved
docs/resources/compliance_security_profile_setting.md Outdated Show resolved Hide resolved
docs/resources/enhanced_security_monitoring_setting.md Outdated Show resolved Hide resolved
@alexott @mgyucht
Apply suggestions from code review
a96465d 
Co-authored-by: Miles Yucht <miles@databricks.com>
@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 16:15 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4393
  • Commit SHA: a96465d3f611ef840e3068387b6dd3353bc72a96

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is January 13, 2025 16:15 — with GitHub Actions Inactive
@alexott alexott enabled auto-merge January 13, 2025 16:15
@alexott alexott added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 3bcab9f Jan 13, 2025
12 checks passed
@alexott alexott deleted the doc/azure-csp-warnings branch January 13, 2025 17:31
tanmay-db added a commit that referenced this pull request Jan 15, 2025
@tanmay-db
[Release] Release v1.63.0
740e581 
### New Features and Improvements

 * Add `fallback` to `databricks_external_location` ([#4372](#4372)).

### Bug Fixes

 * Send only what is required in Update of `databricks_credential` ([#4349](#4349)).

### Documentation

 * Add `MANAGE` privilege to the relevant UC resources ([#4371](#4371)).
 * Add a note about schema evolution and `databricks_sql_table` ([#4352](#4352)).
 * Add description of `clean_rooms_notebook_task` in `databricks_job` ([#4368](#4368)).
 * Add docs for cluster attributes for clusters assigned to groups ([#4359](#4359)).
 * Add note about use of `azurerm_databricks` for enhanced security settings ([#4393](#4393)).
 * Clarify views sharing in `databricks_share` ([#4378](#4378)).
 * Document job edit_mode ([#4354](#4354)).

### Internal Changes

 * Auto generated customizable schemas ([#4356](#4356)).
 * Disable `terraform fmt` in exporter to workaround build issues ([#4394](#4394)).
 * Fixed redundant optional owners in share resource and bumped Go SDK ([#4396](#4396)).
 * Load auto-generated resources and data sources ([#4367](#4367)).
 * Migrate workflows that need write access to use hosted runners ([#4377](#4377)).
 * Remove TF annotations on TFSDK models ([#4383](#4383)).
 * Restart Cluster before Library Installation ([#4384](#4384)).

### Dependency Updates

 * Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0 ([#4374](#4374)).
 * Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1 ([#4397](#4397)).

### Exporter

 * Add exporting of `for_each_task` in jobs ([#4347](#4347)).
 * Add references for missing permissions/grants types ([#4390](#4390)).
 * Support for group assigned clusters ([#4361](#4361)).
 * Use Go SDK to list clusters ([#4385](#4385)).
 * Use `Workspace.Export` from Go SDK for notebooks/files ([#4391](#4391)).
@tanmay-db tanmay-db mentioned this pull request Jan 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
@tanmay-db
[Release] Release v1.63.0 (#4400)
70ac668 
### New Features and Improvements

* Add `fallback` to `databricks_external_location`
([#4372](#4372)).


### Bug Fixes

* Send only what is required in Update of `databricks_credential`
([#4349](#4349)).


### Documentation

* Add `MANAGE` privilege to the relevant UC resources
([#4371](#4371)).
* Add a note about schema evolution and `databricks_sql_table`
([#4352](#4352)).
* Add description of `clean_rooms_notebook_task` in `databricks_job`
([#4368](#4368)).
* Add docs for cluster attributes for clusters assigned to groups
([#4359](#4359)).
* Add note about use of `azurerm_databricks` for enhanced security
settings
([#4393](#4393)).
* Clarify views sharing in `databricks_share`
([#4378](#4378)).
* Document job edit_mode
([#4354](#4354)).


### Internal Changes

* Auto generated customizable schemas
([#4356](#4356)).
* Disable `terraform fmt` in exporter to workaround build issues
([#4394](#4394)).
* Fixed redundant optional owners in share resource and bumped Go SDK
([#4396](#4396)).
* Load auto-generated resources and data sources
([#4367](#4367)).
* Migrate workflows that need write access to use hosted runners
([#4377](#4377)).
* Remove TF annotations on TFSDK models
([#4383](#4383)).
* Restart Cluster before Library Installation
([#4384](#4384)).


### Dependency Updates

* Bump github.com/zclconf/go-cty from 1.15.1 to 1.16.0
([#4374](#4374)).
* Bump github.com/zclconf/go-cty from 1.16.0 to 1.16.1
([#4397](#4397)).


### Exporter

* Add exporting of `for_each_task` in jobs
([#4347](#4347)).
* Add references for missing permissions/grants types
([#4390](#4390)).
* Support for group assigned clusters
([#4361](#4361)).
* Use Go SDK to list clusters
([#4385](#4385)).
* Use `Workspace.Export` from Go SDK for notebooks/files
([#4391](#4391)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexott @mgyucht