Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Update Contributing guide #4404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Internal] Update Contributing guide #4404

wants to merge 1 commit into from

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Jan 16, 2025

Changes

Update contributing guide to refer to NEXT_CHANGELOG.md

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@mgyucht mgyucht requested review from a team as code owners January 16, 2025 13:24
@mgyucht mgyucht requested review from rauchy and removed request for a team January 16, 2025 13:24
@mgyucht mgyucht temporarily deployed to test-trigger-is January 16, 2025 13:24 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is January 16, 2025 13:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4404
  • Commit SHA: d6c13f905d2132644ebc69dda4d5be08023c4899

Checks will be approved automatically on success.

alexott
alexott reviewed Jan 16, 2025
View reviewed changes
CONTRIBUTING.md
@@ -51,6 +51,8 @@ Code contributions—bug fixes, new development, test improvement — all follow
git commit -m "commit message here"
```

1. Document your changes in the `NEXT_CHANGELOG.md` under the appropriate heading.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may lead to conflicts when we have many PRs in parallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott left review comments

@rauchy rauchy Awaiting requested review from rauchy rauchy is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgyucht @alexott