Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix drift in databricks_cluster when is_single_node is set to true #4416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Fix drift in databricks_cluster when is_single_node is set to true #4416

wants to merge 1 commit into from
+50 −6

Conversation

ashenm
Copy link
Contributor

@ashenm ashenm commented Jan 17, 2025

Changes

Fixes #4360

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@ashenm ashenm requested review from a team as code owners January 17, 2025 16:20
@ashenm ashenm requested review from mgyucht and removed request for a team January 17, 2025 16:20
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4416
  • Commit SHA: 506d8eecd88d98feaf2c8e70d1b366b1c9f3e2f8

Checks will be approved automatically on success.

@ashenm
Copy link
Contributor Author

ashenm commented Jan 17, 2025

@alexott please take a stab at it when u get a slot

@alexott
Copy link
Contributor

alexott commented Jan 17, 2025

Please add tests for it - we have example of test for CustomizeDiff in resource_sql_table

@ashenm ashenm deployed to test-trigger-is January 17, 2025 16:30 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht Awaiting requested review from mgyucht mgyucht is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Configuration drift in databricks_cluster when is_single_node is set to true
2 participants
@ashenm @alexott