-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lookml/ingestion): Skip unreferenced or improperly loaded Lookml view files #12351
fix(lookml/ingestion): Skip unreferenced or improperly loaded Lookml view files #12351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
84bec2c
to
9c44993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the lookml docs and/or emit_reachable_views_only
config docs to reflect current limitations.
Can lookml tests be updated to validate this reporting is working as expected ?
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
Outdated
Show resolved
Hide resolved
ead32b0
to
6e82ec4
Compare
Checklist