Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Lidl (Filialgeschäft)' (community contribution) #2394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datenanfragen-community-edits
Copy link
Collaborator

@datenanfragen-community-edits datenanfragen-community-edits commented Oct 9, 2023

This suggestion was submitted through the website.

Edit in company JSON generator

@WebworkrNet
Copy link
Contributor

I have opened this issue via datenanfragen.de.
You can contact me if you have any questions.

"email": "datenschutz@lidl-shop.de",
"web": "https://www.lidl.de/",
"name": "Lidl (Filialgeschäft)",
"address": "Lidl Vertriebs-GmbH & Co. KG",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

"email": "datenschutz@lidl-shop.de",
"web": "https://www.lidl.de/",
"name": "Lidl (Filialgeschäft)",
"address": "Lidl Vertriebs-GmbH & Co. KG",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Lidl Vertriebs-GmbH & Co. KG) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

@WebworkrNet
Copy link
Contributor

Related to #2395, #2396, #2397.

@baltpeter
Copy link
Member

This one is unfortunately really not easy. There's two problems:

  • According to https://www.lidl.de/c/datenschutz/s10007528 (as you mentioned in the comment), there is no single controller that is responsible for all stores. There are literally hundreds of "Lidl Vertriebs-GmbH & Co. KG"s all over Germany (cf. https://www.northdata.de/Lidl+Vertriebs-GmbH+%26+Co%20+KG). And as far as I can tell, those are not different establishments of the same company, but actual separate legal entities. So, we cannot just lump them all into the same record. Unless we can find a single parent company (I couldn't), we would need a record for each one.

  • As per our policy (currently unfortunately unwritten, but I am planning to work on that, cf. Better document our policies #2336), every piece of information in the record needs to have a publicly available (online) source. This is to ensure that a) anyone can actually verify the information and b) we want to implement automatic change detection in the future. As such, a piece of paper in a store somewhere (or a photo of that) won't do.

    However, that's not too much of a problem in this case. The privacy policy on the website in combination with the relevant Handelsregistereintrag should be fine.

Copy link
Collaborator

@fm fm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, clicked the wrong button.

@fm fm closed this Nov 6, 2024
@fm fm reopened this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

5 participants