Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_layout_properties(): type and ids fixed for LABEL=FALSE (#604) #605

Conversation

markheckmann
Copy link
Contributor

Fix: This PR corrects the assignment of the placeholder information in plot_layout_properties() for labels = FALSE) (see #604).

Note: Fixes part of the issue. See suggestions at the bottom of #604


devtools::load_all()
p <- testthat::test_path("docs_dir/test-content-order.pptx")
x <- read_pptx(p)
plot_layout_properties(x, "Many Contents", labels = FALSE)

BEFORE
Types and type ids are not assigned correctly.

image

NOW

Types and type ids are assigned correctly (albeit with room for improvement, see suggestion at bottom in #604)

image

`ph_location_type()` now throws an informative error if ...
- `id` for a `type` is our of range (davidgohel#602)
- type exists but is not present in current layout

also: improved error message if type is unknown
Merge branch 'issue_604_plot_layout_props_labeling_' of github.com:markheckmann/officer into issue_604_plot_layout_props_labeling_

# Conflicts:
#	NEWS.md
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.53%. Comparing base (626f18f) to head (995107c).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
R/pptx_informations.R 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   83.19%   83.53%   +0.33%     
==========================================
  Files          40       41       +1     
  Lines        5720     5832     +112     
==========================================
+ Hits         4759     4872     +113     
+ Misses        961      960       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidgohel davidgohel merged commit b6f053c into davidgohel:master Sep 11, 2024
4 of 5 checks passed
@markheckmann markheckmann deleted the issue_604_plot_layout_props_labeling_ branch September 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants