fix: status bar visibilitiy (#770)

davidlday · Sep 22, 2024 · 85debee · 85debee
1 parent 052da10
commit 85debee
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/Linter.ts b/src/Linter.ts
@@ -138,10 +138,11 @@ export class Linter implements CodeActionProvider {
 
   // Editor Changed
   public editorChanged(editor: TextEditor | undefined, lint: boolean): void {
-    if (editor) {
-      this.documentChanged(editor.document, lint);
-    } else {
+    if (!editor) {
       this.statusBarManager.hide();
+      return;
+    } else {
+      this.documentChanged(editor.document, lint);
     }
   }
 
@@ -150,7 +151,10 @@ export class Linter implements CodeActionProvider {
     document: TextDocument | undefined,
     lint: boolean,
   ): void {
-    if (document) {
+    if (!document) {
+      this.statusBarManager.hide();
+      return;
+    } else {
       if (this.configManager.isSupportedDocument(document)) {
         this.statusBarManager.show();
         if (lint) {
@@ -159,8 +163,6 @@ export class Linter implements CodeActionProvider {
           }
           this.requestLint(document);
         }
-      } else {
-        this.statusBarManager.hide();
       }
     }
   }

diff --git a/src/extension.ts b/src/extension.ts
@@ -69,7 +69,12 @@ export function activate(context: vscode.ExtensionContext): void {
   // Register onDidChangeActiveTextEditor event - request lint
   context.subscriptions.push(
     vscode.window.onDidChangeActiveTextEditor((editor) => {
-      linter.editorChanged(editor, configMan.isLintOnChange());
+      if (editor !== undefined) {
+        linter.editorChanged(
+          vscode.window.activeTextEditor,
+          configMan.isLintOnChange(),
+        );
+      }
     }),
   );