Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message, fix transaction error recording #181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qianl15
Copy link
Member

@qianl15 qianl15 commented Jan 18, 2025

  • Found an issue where DBApi error is not properly recorded to the database, thus did not guarantee OAOO behavior. This PR fixes the issue.
  • Add a hint error message of InvalidRequestError for transactions, which is often caused by calling commit() and rollback() within a transaction function.
  • Improve error message for get_status() within a workflow. If it finds a recorded output but cannot parse workflow status from it, it means the output is corrupted and potentially the workflow is non-deterministic.

Added a bunch of OAOO tests to make sure the behavior is correct.

@qianl15 qianl15 changed the title Fix transaction recording, add hint to invalid request error Better error message, fix transaction error recording Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant