V2 Stored Procedure Support #697
Conversation
|
"normally, this would point to the class object instance". DBOS is already not doing that, usually inside a DBOS static function 'this' is 'undefined'. |
I'm not sure what this is in reference to |
Try reading it as normally, 'this' would point to the class object instance. DBOS is already giving 'undefined' as 'this' in its static functions. |
|
I should have updated the initial PR comment. The Function.apply approach didn't work - the 'this' object gets reset when you call into a context method like 'DBOS.workflowID'. Global state is the only option for storing context state so the 'DBOS' statics can retrieve them. I confirmed that the global 'plv8' object is shared between connections. So we hang the DBOS context info off that object where the DBOS context methods can get it. That context info is set and deleted in the generated proc to avoid information leakage |
|
Merge when you feel comfortable, I'm OOF until after release anyway |
This was removed in #697. Re-enabling it and adding tests.
Adds
@DBOS.storedProcedure(aka v2 stored procedures)Note, plv8 does not support node's
AsyncLocalStorageAPI. Since all DBOS functions are static methods in order to support decorators, the stored proc runtime usesFunction.applyto provide a customthisobject that the stored proc runtime version ofDBOScontext methods accesses. This does change the expected behavior ofthisobject in static methods - normally,thiswould point to the class object instance. However, access to the class object instance viathisisn't very useful to stored procedures anyway. If we feel it's important to maintain access to the class object instance, we can add a property to the customthisobject that references the class object.