Use status for queue fix and optimization #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uplevel the test to v2
chuck-dbos
changed the title
I added a test now that failed on old and passes on new. A bit of unnatural act there, let me know if you have better ideas on how to do this. Sorry for the clutter too, I updated the test to use v2 API because it is just much easier to launch() and shutdown(). Python is ongoing, the branch exists, I've tested the same thing manually, and need to automate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a workflow, look at any existing record in the workflow status table.
If the workflow is already complete (SUCCESS or ERROR) do nothing (let the caller retrieve the result from the handle)
If the workflow is now ENQUEUED, ensure there is a workflow_queue record for it, but do not add such records if the workflow has moved past that state.