Dedupe Issue #303

dbosak01 · Oct 26, 2023 · 790ab82 · 790ab82
1 parent 3376705
commit 790ab82
Show file tree

Hide file tree

Showing 69 changed files with 143 additions and 92 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: reporter
 Type: Package
 Title: Creates Statistical Reports 
-Version: 1.4.2
+Version: 1.4.3
 Authors@R: c( 
     person("David", "Bosak", email = "dbosak01@gmail.com", role = c("aut", "cre")),
     person("Kevin", "Kramer", email = "kkrame02@amgen.com", role = "ctb"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,8 @@
+# reporter 1.4.3
+
+* Fix dedupe functionality on `define()` function when values are not unique. 
+* Fixes for CRAN.
+
 # reporter 1.4.2
 
 * Added example for page breaking.

diff --git a/R/utilities.R b/R/utilities.R
@@ -891,11 +891,11 @@ dedupe_pages <- function(pgs, defs) {
           w <- min(nchar(dat[[def$var_c]])) # Take min to exclude label row
           v <- paste0(rep(" ", times = w), collapse = "")
 
-          # dat[[def$var_c]] <- ifelse(changed(dat[[def$var_c]]), 
-          #                            dat[[def$var_c]], v) 
+          dat[[def$var_c]] <- ifelse(changed(dat[[def$var_c]]),
+                                     dat[[def$var_c]], v)
 
-          dat[[def$var_c]] <- ifelse(!duplicated(dat[[def$var_c]]), 
-                                     dat[[def$var_c]], v) 
+          # dat[[def$var_c]] <- ifelse(!duplicated(dat[[def$var_c]]), 
+          #                            dat[[def$var_c]], v) 
         }
       }
     }

diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/LICENSE.html b/docs/LICENSE.html
diff --git a/docs/articles/index.html b/docs/articles/index.html
diff --git a/docs/articles/reporter-break.html b/docs/articles/reporter-break.html
diff --git a/docs/articles/reporter-faq.html b/docs/articles/reporter-faq.html
diff --git a/docs/articles/reporter-figure.html b/docs/articles/reporter-figure.html
diff --git a/docs/articles/reporter-fonts.html b/docs/articles/reporter-fonts.html
diff --git a/docs/articles/reporter-listing.html b/docs/articles/reporter-listing.html
diff --git a/docs/articles/reporter-more.html b/docs/articles/reporter-more.html
diff --git a/docs/articles/reporter-pageby.html b/docs/articles/reporter-pageby.html
diff --git a/docs/articles/reporter-rtf.html b/docs/articles/reporter-rtf.html
diff --git a/docs/articles/reporter-spanning.html b/docs/articles/reporter-spanning.html
diff --git a/docs/articles/reporter-stub.html b/docs/articles/reporter-stub.html
diff --git a/docs/articles/reporter-styles.html b/docs/articles/reporter-styles.html
diff --git a/docs/articles/reporter-super.html b/docs/articles/reporter-super.html
diff --git a/docs/articles/reporter-table.html b/docs/articles/reporter-table.html
diff --git a/docs/articles/reporter-text.html b/docs/articles/reporter-text.html
diff --git a/docs/articles/reporter-title_header.html b/docs/articles/reporter-title_header.html
diff --git a/docs/articles/reporter-wrap.html b/docs/articles/reporter-wrap.html
diff --git a/docs/articles/reporter.html b/docs/articles/reporter.html
diff --git a/docs/authors.html b/docs/authors.html
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/news/index.html b/docs/news/index.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -19,7 +19,7 @@ articles:
   reporter-title_header: reporter-title_header.html
   reporter-wrap: reporter-wrap.html
   reporter: reporter.html
-last_built: 2023-09-30T05:13Z
+last_built: 2023-10-26T01:24Z
 urls:
   reference: https://reporter.r-sassy.org/reference
   article: https://reporter.r-sassy.org/articles

diff --git a/docs/reference/NotesOnPDF.html b/docs/reference/NotesOnPDF.html
diff --git a/docs/reference/add_content.html b/docs/reference/add_content.html
diff --git a/docs/reference/add_style.html b/docs/reference/add_style.html
diff --git a/docs/reference/cell_style.html b/docs/reference/cell_style.html
diff --git a/docs/reference/column_defaults.html b/docs/reference/column_defaults.html
diff --git a/docs/reference/create_plot.html b/docs/reference/create_plot.html
diff --git a/docs/reference/create_report.html b/docs/reference/create_report.html
diff --git a/docs/reference/create_style.html b/docs/reference/create_style.html
diff --git a/docs/reference/create_table.html b/docs/reference/create_table.html
diff --git a/docs/reference/create_text.html b/docs/reference/create_text.html
diff --git a/docs/reference/define.html b/docs/reference/define.html
diff --git a/docs/reference/footnotes.html b/docs/reference/footnotes.html
diff --git a/docs/reference/ftn.html b/docs/reference/ftn.html