docs update #55
docs update #55
Conversation
|
@aaronbini mind confirming those oauth endpoints should be shown in the docs? |
@MitchellBarker is this for public API docs? If so, those endpoints don't need to be added. They just get hit as part of the OAuth flow that gets kicked off in the UI. |
@aaronbini Yup! Just removed them then and tagged you in the related cloud PR :) |
| @@ -5843,61 +5859,6 @@ components: | |||
| required: | |||
| - filters | |||
| - pagination | |||
| PatchedExtendedAttributesRequest: | |||
There was a problem hiding this comment.
@sidpatel13 @ericbaumann Just tagging to make sure this removal is correct. Haven't delved into why it's not being added now, since I assume one of yall know
There was a problem hiding this comment.
I don't think we've made any changes here intentionally - i still see patch as a supported method on the detail view for EAT (link)
There was a problem hiding this comment.
Oh we're actually good here. Turns out the body just changed to match the non-patch. The request and its docs didn't disappear.
Basically the docs generator was trying to be smart about making all parameters in the patch body optional - which isn't actually true for that route anyway. So should be fine to merge this
There was a problem hiding this comment.
Thanks for checking!
Updated docs. Need to verify the following are good:
BaseConnectionPatchedExtendedAttributesRequestAddition of/api/v3/accounts/{account_id}/oauth/authorize/{integration}/Addition of/api/v3/accounts/{account_id}/oauth/callback/{integration}/