Add tests for batch_id and change expected output for format_batch_start

dbt-labs · Jan 17, 2025 · fe73096 · fe73096
1 parent 85e0e32
commit fe73096
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/tests/unit/materializations/incremental/test_microbatch.py b/tests/unit/materializations/incremental/test_microbatch.py
@@ -602,13 +602,25 @@ def test_offset_timestamp(self, timestamp, batch_size, offset, expected_timestam
     def test_truncate_timestamp(self, timestamp, batch_size, expected_timestamp):
         assert MicrobatchBuilder.truncate_timestamp(timestamp, batch_size) == expected_timestamp
 
+    @pytest.mark.parametrize(
+        "batch_size,start_time,expected_formatted_start_time",
+        [
+            (BatchSize.year, datetime(2020, 1, 1, 1), "20200101"),
+            (BatchSize.month, datetime(2020, 1, 1, 1), "20200101"),
+            (BatchSize.day, datetime(2020, 1, 1, 1), "20200101"),
+            (BatchSize.hour, datetime(2020, 1, 1, 1), "20200101T01"),
+        ],
+    )
+    def test_batch_id(self, batch_size, start_time, expected_formatted_start_time):
+        assert MicrobatchBuilder.batch_id(start_time, batch_size) == expected_formatted_start_time
+
     @pytest.mark.parametrize(
         "batch_size,batch_start,expected_formatted_batch_start",
         [
-            (BatchSize.year, datetime(2020, 1, 1, 1), "2020-01-01"),
-            (BatchSize.month, datetime(2020, 1, 1, 1), "2020-01-01"),
-            (BatchSize.day, datetime(2020, 1, 1, 1), "2020-01-01"),
-            (BatchSize.hour, datetime(2020, 1, 1, 1), "2020-01-01 01:00:00"),
+            (BatchSize.year, datetime(2020, 1, 1, 1), "20200101"),
+            (BatchSize.month, datetime(2020, 1, 1, 1), "20200101"),
+            (BatchSize.day, datetime(2020, 1, 1, 1), "20200101"),
+            (BatchSize.hour, datetime(2020, 1, 1, 1), "20200101T01"),
         ],
     )
     def test_format_batch_start(self, batch_size, batch_start, expected_formatted_batch_start):