[ADAP-774] fix snowflake_warehouse issue with dynamic tables #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…house vs warehouse
|
@mikealfare currently after making modifications I'm seeing
|
McKnight-42
commented
Aug 8, 2023
dbt/include/snowflake/macros/materializations/dynamic_table/ddl.sql
Outdated
Show resolved
Hide resolved
… and add a alias on describe macro so we are taking in the warehouse field as snowflake_warehouse
McKnight-42
commented
Aug 9, 2023
dbt/include/snowflake/macros/materializations/dynamic_table/ddl.sql
Outdated
Show resolved
Hide resolved
McKnight-42
requested review from
colin-rogers-dbt
and removed request for
VersusFacit
mikealfare
reviewed
Aug 9, 2023
McKnight-42
changed the title
mikealfare
reviewed
Aug 9, 2023
mikealfare
approved these changes
Aug 9, 2023
8 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
* update RELEASE_BRANCH env * start work on adap-774 to migrate dynmic tables to use snowflake_warehouse vs warehouse * revert some stuff back to wareshouse as it is what snwoflake expects, and add a alias on describe macro so we are taking in the warehouse field as snowflake_warehouse * change location of comparion to snowflake_warehouse and warehouse * remove uneeded addition * revert a field (cherry picked from commit 5d5c18e)
mikealfare
pushed a commit
that referenced
this pull request
Aug 16, 2023
…746) * start work on adap-774 to migrate dynamic tables to use snowflake_warehouse vs warehouse * revert some stuff back to warehouse as it is what snowflake expects, and add an alias on describe macro so we are taking in the warehouse field as snowflake_warehouse (cherry picked from commit 5d5c18e) Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
philippe-boyd-maxa
pushed a commit
to maxa-ai/dbt-snowflake
that referenced
this pull request
Nov 27, 2023
…s#727) * update RELEASE_BRANCH env * start work on adap-774 to migrate dynmic tables to use snowflake_warehouse vs warehouse * revert some stuff back to wareshouse as it is what snwoflake expects, and add a alias on describe macro so we are taking in the warehouse field as snowflake_warehouse * change location of comparion to snowflake_warehouse and warehouse * remove uneeded addition * revert a field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
users are being given incorrect information around required configs for
dynamic tablesin which they are being told thatwarehouseis not provided but they should actually be providingsnowflake_warehouse.Solution
TODO:
Checklist