add metric alias to sl api #6775
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
size: large
| @@ -265,6 +267,7 @@ createQuery( | |||
| ```graphql | |||
| MetricInput { | |||
| name: String! | |||
| alias: String! | |||
There was a problem hiding this comment.
@courtneyholcomb added alias from @Jstein77 duplicate PR
| @@ -403,6 +325,19 @@ select * from {{ | |||
| }} | |||
| ``` | |||
|
|
|||
| ### Query by all dimensions | |||
There was a problem hiding this comment.
@courtneyholcomb added query by all dimensions from @Jstein77 duplicate PR
however should it be semantic_layer.query_with_all_group_bys or semantic_layer.group_by_all()? the example doesn't match the text above it?
There was a problem hiding this comment.
@mirnawong1 it's semantic_layer.query_with_all_group_bys
I'm wondering if this should be documented at all, though? This was an ask by Sigma, and we decided to put it into a separate method instead of just query because that's not really the intended way of using the Semantic Layer, and there is a caveat to it: you can (possibly) get incorrect data if you don't know what you're doing and reaggregate metrics that aren't supposed to be reaggregated.
IMO regular users should just stick to query() and we shouldn't promise stability and/or backwards compatibility to query_with_all_group_bys() in the long run.
I think we should also hear Courtney's and Jordan's thoughts on this, though.
There was a problem hiding this comment.
sounds good, thank you! i copied it over from Jordan's pr so would be great to get clarity!
There was a problem hiding this comment.
@serramatutu I think we should document it! It's a useful endpoint that can simplify certain query requests for users. I also don't think there's much downside in putting documenting it.
| | 2023-12-01 | 1500.75 | | ||
| | 2023-12-02 | 1725.50 | | ||
| | 2023-12-03 | 1850.00 | | ||
| ``` |
There was a problem hiding this comment.
Hiya @mirnawong1
Probs just me being picky but the table appears mis-aligned. Should the "|" be shifted to the right a bit?
Kind Regards
Natalie
There was a problem hiding this comment.
Hiya @mirnawong1
Ignore the first comment I made lol. I submitted the post too quickly.
I've approved this for you and left one question / suggestion
Kind Regards
Natalie
natalie's feedback on table
this pr adds new info that you can query metric aliases in the jdbc and graph api for the semantic layer.
updated jdbc and graphql api doc, as well as added a release note entry
linear: https://linear.app/dbt-labs/issue/SL-3245/support-metric-aliases#comment-ab55cb17
🚀 Deployment available! Here are the direct links to the updated files: