Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-EU VAT-IDs #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added non-EU VAT-IDs #37

wants to merge 2 commits into from

Conversation

luggesexe
Copy link

In favour of #3 (Non EU vat numbers)

In favour of ddeboer#3 (Non EU vat numbers)
@GrahamCampbell
Copy link
Contributor

GrahamCampbell commented Mar 3, 2021

GB is also non-EU.

@luggesexe
Copy link
Author

GB is also non-EU.

Changed. Also added some LATAM.

@luggesexe
Copy link
Author

@ddeboer, would you merge my PR?

Kind regards,
Lukas-Adrian

@sirn-se
Copy link

sirn-se commented Mar 31, 2022

Saw the PR as I needed to check some things in this repo, and merging this would make it unusable to us. Let me explain.

As the repo is built it concerns EU VAT system. The VIES service, used for full validation, is strictly EU - it will never return valid results for another country (well, except Northern Ireland, but that's another story).

Within EU the validity has a very practical use, as it will change how sales tax is applied. If it starts returning true for non-EU VAT numbers it can no longer be used to assert tax eligibility. Which is, at least, a breaking change.

So first, repo owner need to decide if this is going to be a generic format validator or a formal EU VAT validator.
If support for non-EU countries are added, it need t o be added as an option or as a new major version as it would be a breaking change.

@luggesexe
Copy link
Author

luggesexe commented Mar 31, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants