PCVR (Rift) support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 23, 2024 08:37
Currently not all available ovr functions are imlemented. Support for Initialize, Entitlement, Message, User and Achievements. - Available functions are: - ovr_IsPlatformInitialized - ovrPlatformInitializeResult_ToString - ovr_GetLoggedInUserID - ovr_GetLoggedInUserLocale - ovr_Entitlement_GetIsViewerEntitled - ovr_Message_GetType - ovrMessageType_ToString - ovr_Message_IsError - ovr_Message_GetError - ovr_Message_GetRequestID - ovr_Message_GetPlatformInitialize - ovr_Message_GetUserAccountAgeCategory - ovr_Message_GetUser - ovr_Message_GetString - ovr_Error_GetMessage - ovr_PlatformInitialize_GetResult - ovr_UserAccountAgeCategory_GetAgeCategory - ovr_User_GetID - ovr_User_GetLoggedInUser - ovr_User_Get - ovr_User_GetDisplayName - ovr_User_GetOculusID - ovr_User_GetImageUrl - ovr_User_GetSmallImageUrl - ovr_UserAgeCategory_Get - ovrID_FromString - ovrID_ToString - ovr_FreeMessage - ovr_Achievements_AddCount - ovr_Achievements_AddFields - ovr_Achievements_Unlock - ovr_Achievements_GetAllDefinitions - ovr_Achievements_GetAllProgress - ovr_Achievements_GetDefinitionsByName - ovr_Achievements_GetProgressByName - ovr_Message_GetAchievementDefinitionArray - ovr_Message_GetAchievementProgressArray - ovr_AchievementProgressArray_GetElement - ovr_AchievementProgressArray_GetNextUrl - ovr_AchievementProgressArray_GetSize - ovr_AchievementProgressArray_HasNextPage - ovr_AchievementProgress_GetBitfield - ovr_AchievementProgress_GetCount - ovr_AchievementProgress_GetIsUnlocked - ovr_AchievementProgress_GetName - ovr_AchievementProgress_GetUnlockTime - ovr_Message_GetAchievementUpdate - ovr_AchievementUpdate_GetJustUnlocked - ovr_AchievementUpdate_GetName - ovr_AchievementDefinitionArray_GetElement - ovr_AchievementDefinitionArray_GetNextUrl - ovr_AchievementDefinitionArray_GetSize - ovr_AchievementDefinitionArray_HasNextPage - ovr_Achievements_GetNextAchievementDefinitionArrayPage - ovr_AchievementDefinition_GetBitfieldLength - ovr_AchievementDefinition_GetName - ovr_AchievementDefinition_GetType - ovrAchievementType_ToString - ovrAchievementType_FromString - ovr_AchievementDefinition_GetTarget - ovr_Achievements_GetNextAchievementProgressArrayPage
|
In my opinion the initialize_android and initialize_android_async should be renamed to initialize_platform and initialize_platform_async. |
added 2 commits
October 24, 2024 16:10
ovr_ApplicationLifecycle_GetLaunchDetails ovr_ApplicationLifecycle_LogDeeplinkResult ovr_LaunchDetails_GetDeeplinkMessage ovr_LaunchDetails_GetDestinationApiName ovr_LaunchDetails_GetLaunchSource ovr_LaunchDetails_GetLaunchType ovr_LaunchDetails_GetLobbySessionID ovr_LaunchDetails_GetMatchSessionID ovr_LaunchDetails_GetTrackingID ovr_LaunchDetails_GetUsers ovrLaunchType_ToString ovrLaunchType_FromString ovr_UserArray_GetElement ovr_UserArray_GetNextUrl ovr_UserArray_GetSize ovr_UserArray_HasNextPage ovr_Application_GetVersion ovr_Message_GetApplicationVersion ovr_ApplicationVersion_GetCurrentCode ovr_ApplicationVersion_GetCurrentName ovr_ApplicationVersion_GetLatestCode ovr_ApplicationVersion_GetLatestName ovr_ApplicationVersion_GetReleaseDate ovr_ApplicationVersion_GetSize
Added for PCVR: application_get_version application_get_launch_details
|
Hi Michael! Thank you for this. I haven't had the chance to test this yet, but at first glance it looks good. There are only two things that I'd like to note: First is that, I believe we still need the The other thing I'd like to see if you can do is to move the |
|
Hi Daniel, thank you for your response.
Before I change things, I would like to make a few comments. I would be happy if you could give me some feedback, then I will change it according to your wishes.
1. I don't understand you autocompletion argument, because all functions are also available in godot_oculus_platform_editor.cpp. Currently I use in each function "#ifdef __ANDROID__" and "#else" for the different implementations. I could also add "#elif defined(_WIN32)" for windows only and "#else" for the rest, which is not supported, like Max or Linux with "return _empty_func_helper();". But if you prefer, I can also reactivate godot_oculus_platform_editor.cpp. Please let me know which one you would like.
2. *REMOVED* => Replaced by auto generated OVR_PlatformLoader.os
|
|
3. I renamed the initialize_android and initialize_android_async to initialize_platform and initialize_platform_async. Do you agree or should I undo it?
|
added 3 commits
October 25, 2024 09:10
…atform/bin/windows/OVR_PlatformLoader.cpp
|
Good news: I found a good solution with SCons for your second point: I changed the SConstruct to generate a src/OVR_PlatformLoader.os from the source demo/addons/godot_oculus_platform/bin/windows/OVR_PlatformLoader.cpp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not all available ovr functions are imlemented. Support for Initialize, Entitlement, Message, User and Achievements.