Updated to Dotnet 9.0.101 #597
Open
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/envs/generate_user_env.sh
JCash
commented
Jan 9, 2025
Comment on lines
+43
to
+46
| if [[ "" == "${JAVA_HOME}" ]]; then | ||
| # select java home for JDK 21 | ||
| JAVA_HOME=`/usr/libexec/java_home -v 21` | ||
| fi |
There was a problem hiding this comment.
I don't have that executable on my machine
I do however have JAVA_HOME set.
And I think it's reasonable to have an environment variable that overrides any automatic resolving.
Comment on lines
+24
to
+27
| if [[ "" == ${PLATFORMSDK_DIR} ]]; then | ||
| echo "Missing PLATFORMSDK_DIR. Please run ./server/envs/generate_user_env.sh to generate it" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
The file exists, but lacks the variable.
| @@ -114,7 +118,7 @@ function install_dotnet() { | |||
| # https://dotnet.microsoft.com/en-us/download/dotnet/9.0 | |||
| # https://github.com/dotnet/core/blob/main/release-notes/9.0/install.md | |||
|
|
|||
| local version="9.0.100-rc.2.24474.11" | |||
| local version="9.0.1xx" | |||
There was a problem hiding this comment.
They haven't yet updated to v9 at their latest version, nor is it possible to write a more inclusive pattern (none that I've found at least)
ekharkunov
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.