Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max rects and pivot point support to texture packer plugin #11

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

JCash
Copy link
Contributor

@JCash JCash commented Nov 5, 2024

No description provided.

@JCash JCash requested review from vlaaad and britzl November 5, 2024 09:36
Copy link

@vlaaad vlaaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -116,7 +135,7 @@ var exportAtlas = function(root)
""
);

output.push("version: \"1.1\""); // our file format version
output.push("version: \"2.0\""); // our file format version
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know we can tell the files apart, if anything goes wrong.

Comment on lines +102 to +105
exportPoint(output, indentLevel+1, "vertices", {x: x1, y: y0}); // TR
exportPoint(output, indentLevel+1, "vertices", {x: x0, y: y0}); // TL
exportPoint(output, indentLevel+1, "vertices", {x: x0, y: y1}); // BL
exportPoint(output, indentLevel+1, "vertices", {x: x1, y: y1}); // BR
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We export a polygon that happens to be a rectangle.

@JCash JCash merged commit 4367162 into main Nov 6, 2024
1 of 17 checks passed
@JCash JCash deleted the tp-maxrects-support branch November 6, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants