Skip to content

Commit

Permalink
[stable/listmonk] add artifacthub annotation (#658)
Browse files Browse the repository at this point in the history
* [stable/listmonk] add artifacthub annotation

* remove dependencies from Chart.yaml when present in order to run conftest

---------

Co-authored-by: Max Williams <max-rocket-internet@users.noreply.github.com>
  • Loading branch information
max-rocket-internet and max-rocket-internet authored Jan 7, 2025
1 parent dcb26ca commit 3ec1596
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/helm-conftest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
uses: actions/checkout@v4.1.7

- name: Install Dependencies
run: apk add --no-cache curl tar
run: apk add --no-cache curl tar yq

- name: Install Conftest
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/helm-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ jobs:
run: |
helm plugin install https://github.com/sigstore/helm-sigstore
for f in *.tgz ; do
echo "$f"
helm sigstore upload "$d"
echo "Running sigstore upload for chart: $f"
helm sigstore upload "$f"
done
- name: Generate Helm repo index.yaml
shell: bash
Expand Down
3 changes: 3 additions & 0 deletions ci/helm-conftest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ while IFS= read -r -d '' chart
do
echo "=============================================================="
echo "helm-conftest running for chart: ${chart}..."

# Remove any dependencies as we are not going to test them
rm -f "${chart}/requirements.yaml"
rm -rf "${chart}/charts"
yq -i 'del(.dependencies)' "${chart}/Chart.yaml"

helm template "${chart}" | conftest -p ci/helm-conftest-policies test -
done < <(find stable -maxdepth 1 -mindepth 1 -print0)
13 changes: 12 additions & 1 deletion stable/listmonk/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.10
version: 0.1.11

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand All @@ -31,3 +31,14 @@ sources:
maintainers:
- name: javad-hajiani
email: no-reply@deliveryhero.com

dependencies:
- name: postgresql
repository: https://charts.bitnami.com/bitnami
version: 11.6.26
condition: postgresql.enable

annotations:
artifacthub.io/links: |
- name: Helm chart source
url: https://github.com/deliveryhero/helm-charts/tree/master/stable/listmonk
10 changes: 8 additions & 2 deletions stable/listmonk/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# listmonk

![Version: 0.1.10](https://img.shields.io/badge/Version-0.1.10-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.1.0](https://img.shields.io/badge/AppVersion-v2.1.0-informational?style=flat-square)
![Version: 0.1.11](https://img.shields.io/badge/Version-0.1.11-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.1.0](https://img.shields.io/badge/AppVersion-v2.1.0-informational?style=flat-square)

A Helm chart for listmonk application

Expand All @@ -17,7 +17,7 @@ helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/listmonk
To install a specific version of this chart:

```console
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/listmonk --version 0.1.10
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/listmonk --version 0.1.11
```

To install the chart with the release name `my-release`:
Expand All @@ -42,6 +42,12 @@ helm install my-release oci://ghcr.io/deliveryhero/helm-charts/listmonk -f value

* <https://github.com/knadh/listmonk>

## Requirements

| Repository | Name | Version |
|------------|------|---------|
| https://charts.bitnami.com/bitnami | postgresql | 11.6.26 |

## Values

| Key | Type | Default | Description |
Expand Down
5 changes: 0 additions & 5 deletions stable/listmonk/requirements.yaml

This file was deleted.

0 comments on commit 3ec1596

Please sign in to comment.