Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/wiremock] fix environment secrets handling #633

Merged
merged 4 commits into from
Nov 21, 2024
Merged

[stable/wiremock] fix environment secrets handling #633

merged 4 commits into from
Nov 21, 2024

Conversation

mshero
Copy link
Contributor

@mshero mshero commented Nov 20, 2024 •
edited
Loading

Description

This PR fixes an issue with environment secrets handling where configured secrets have not been added to the env spec.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@mshero mshero self-assigned this Nov 20, 2024
@mshero mshero requested a review from a team as a code owner November 20, 2024 15:58
@mshero mshero enabled auto-merge (squash) November 21, 2024 07:26
@mshero mshero merged commit 5b3e724 into master Nov 21, 2024
7 checks passed
@mshero mshero deleted the fix/wiremock-secrets-handling branch November 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreymundo nreymundo nreymundo approved these changes

Assignees

@mshero mshero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshero @nreymundo