Preparing for deltalake v0.17 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyler
force-pushed
the
deltalake-0.17-prep
branch
from
5b9d1cb to
a303d18
Compare
rtyler
force-pushed
the
deltalake-0.17-prep
branch
from
a303d18 to
0f259a2
Compare
|
I am building other branches off of this one to help do integration testing and qualification of the next |
mightyshazam
reviewed
Jan 9, 2024
| @@ -754,7 +754,7 @@ impl IngestProcessor { | |||
| let dlq = dead_letter_queue_from_options(&opts).await?; | |||
| let transformer = Transformer::from_transforms(&opts.transforms)?; | |||
| let table = delta_helpers::load_table(table_uri, HashMap::new()).await?; | |||
| let coercion_tree = coercions::create_coercion_tree(&table.get_metadata()?.schema); | |||
| let coercion_tree = coercions::create_coercion_tree(table.schema().unwrap()); | |||
There was a problem hiding this comment.
Why switch from ? to unwrap? While this shouldn't really be a candidate for panicking, it is a possibility. Is that what we want?
mightyshazam
reviewed
Jan 9, 2024
| @@ -947,11 +947,11 @@ impl IngestProcessor { | |||
|
|
|||
| if self | |||
| .delta_writer | |||
| .update_schema(self.table.get_metadata()?)? | |||
| .update_schema(self.table.state.delta_metadata().unwrap())? | |||
mightyshazam
reviewed
Jan 9, 2024
| { | ||
| info!("Table schema has been updated"); | ||
| // Update the coercion tree to reflect the new schema | ||
| let coercion_tree = coercions::create_coercion_tree(&self.table.get_metadata()?.schema); | ||
| let coercion_tree = coercions::create_coercion_tree(self.table.schema().unwrap()); |
mightyshazam
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of refactorings necessary, the dynamodb lock mechanism will be changing too!