add filename length checker to file obfuscator #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TheBearodactyl 👏 Thanks for the contribution! I noticed that you’ve attempted to truncate the overly long encoded filename. However, I believe it might not be ideal for a hider to modify a user’s data — including filenames — without explicit consent. One potential solution could be to add a toggle in the settings, allowing users to enable or disable truncation. Alternatively, a more robust approach might be to store the overly long filename in a separate file. |
|
sure, lemme add that rq |
|
Mind if I switch the PR to a draft for now? Just let me know when you think it's good to go! |
|
sure
…On Sat, Jan 11, 2025, 7:39 PM deltazefiro ***@***.***> wrote:
Mind if I switch the PR to a draft for now? Just let me know when you
think it's good to go!
—
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3JG4Y4P3MCQ4OXP42UPEGD2KG2VZAVCNFSM6AAAAABUYWZ4POVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGQ4TONBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.