Use reusable workflows to break up tests #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemann
force-pushed
the
cursor-test
branch
2 times, most recently
from
f0a5e2e to
9001e67
Compare
bdemann
commented
Oct 8, 2024
bdemann
changed the title
2 tasks
lastmjs
requested changes
Oct 18, 2024
lastmjs
requested changes
Oct 18, 2024
lastmjs
requested changes
Oct 22, 2024
.github/workflows/test.yml
Outdated
| @@ -70,7 +70,7 @@ jobs: | |||
| ') }}" | |||
|
|
|||
| IS_MAIN_BRANCH_PUSH="${{ steps.set-conditions.outputs.is_main_branch_push }}" | |||
| IS_MAIN_BRANCH_MERGE_FROM_RELEASE_PUSH="${{ steps.set-conditions.outputs.is_main_branch_merge_from_release_push }}" | |||
| IS_MAIN_BRANCH_PUSH_FROM_RELEASE_MERGE="${{ steps.set-conditions.outputs.is_main_branch_push_from_release_merge }}" | |||
There was a problem hiding this comment.
Shouldn't we use this environment variable name everywhere?
| @@ -23,14 +23,14 @@ runs: | |||
| run: | | |||
| # Define conditions using shell variables | |||
| IS_MAIN_PUSH=${{ github.ref == 'refs/heads/main' && !contains(github.event.head_commit.message, 'demergent-labs/release--') }} | |||
| IS_MAIN_MERGE_RELEASE=${{ github.ref == 'refs/heads/main' && contains(github.event.head_commit.message, 'demergent-labs/release--') }} | |||
| IS_MAIN_PUSH_RELEASE=${{ github.ref == 'refs/heads/main' && contains(github.event.head_commit.message, 'demergent-labs/release--') }} | |||
There was a problem hiding this comment.
IS_MAIN_PUSH_RELEASE...can we rename this to IS_MAIN_BRANCH_PUSH_FROM_RELEASE_MERGE?
lastmjs
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.