Fix query param name for custom related pk name #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the related model's primary key is not named `id`, use the right primary key name when constructing the query param name.
I do not see any reason for the custom related model resolution logic. But maybe I don't understand the intent...
Do not apply the `width: 100% !important` rule to select2 components on regular admin forms.
Do not apply the `width: 100% !important` rule to select2 components on regular admin forms.
|
Oops, seems like I've created this pull request from the main branch of my fork, which contains all kinds of unrelated changes. Let me know if there is interest in fixing the original "custom related pk name" problem and I will clean up this pr. |
|
as i promised, here is the current one: https://github.com/vigo/django-admin-list-filter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the related model's primary key is not named
id, use the right primary key name when constructing the query param name.I've also sneaked in two loosely related changes, feel free to cherry-pick them:
get_queryset_for_fieldwith a simplefield.related_model.objects.get_queryset()call. If there is a reason for not using that, feel free to remove, but if that is the case, it would also help future contributors if there was an explanatory comment present.