Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/http): Support compression on text/event-stream #27776

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(ext/http): Support compression on text/event-stream #27776

wants to merge 1 commit into from

Conversation

aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Jan 22, 2025 •
edited
Loading

close #27725

@nickchomey nickchomey mentioned this pull request Jan 22, 2025
Open
@aaron-ang aaron-ang force-pushed the event-stream-compression branch from 771fd97 to a9aa0a9 Compare January 23, 2025 02:46
@aaron-ang aaron-ang marked this pull request as ready for review January 23, 2025 02:46
@aaron-ang
Copy link
Contributor Author

aaron-ang commented Jan 23, 2025 •
edited
Loading

ext/web exposes a CompressionStream in 14_compression.js, and the internals bind to compression.rs

#22562 expresses some concerns about compressing streams which might delay server response.

I did some digging and found a test case that checks for flushing on each streamed resource, so technically it should support compression for SSE.

@aaron-ang aaron-ang marked this pull request as draft January 23, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support compression on text/event-stream
1 participant
@aaron-ang