Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pre-commit 시 spotlessApply 실행 #412

Merged
merged 4 commits into from
Jun 21, 2024
Merged

chore: pre-commit 시 spotlessApply 실행 #412

merged 4 commits into from
Jun 21, 2024

Conversation

char-yb
Copy link
Member

@char-yb char-yb commented Jun 21, 2024 •
edited
Loading

🌱 관련 이슈

📌 작업 내용 및 특이사항

AS-IS

  • 기존 pre-commit은 spotless를 check만 진행

TO-BE

  • 수정된 pre-commit은 spotlessApply하도록 진행

📝 참고사항

  • 적용 후 gradle에서 updateGitHooks 실행할 것
  • 그래도 안된다면 .git/hooks 에서 pre-commit 지우고 실행해볼 것

📚 기타

@char-yb char-yb added 🥉 P3 급하지 않은 이슈 ⚙️ chore 빌드 및 CI/CD labels Jun 21, 2024
@char-yb char-yb self-assigned this Jun 21, 2024
@char-yb char-yb requested review from kdomo and uwoobeat as code owners June 21, 2024 03:01
@char-yb char-yb linked an issue Jun 21, 2024 that may be closed by this pull request
⚙️ pre-commit 시 spotlessApply 실행 #411
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
218 New issues
0 Accepted issues

Measures
0 Security Hotspots
49.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kdomo
kdomo approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@kdomo kdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사함니당

uwoobeat
uwoobeat approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘돌아가면코드좀훔쳐갈게요

@char-yb char-yb merged commit 5dc5415 into develop Jun 21, 2024
3 checks passed
@github-actions github-actions bot added the merged 머지된 PR label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uwoobeat uwoobeat uwoobeat approved these changes

@kdomo kdomo kdomo approved these changes

Assignees

@char-yb char-yb

Labels
⚙️ chore 빌드 및 CI/CD merged 머지된 PR 🥉 P3 급하지 않은 이슈
Projects
10mm-server
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚙️ pre-commit 시 spotlessApply 실행
3 participants
@char-yb @kdomo @uwoobeat