feat: Firebase Crashlytics 모듈 추가 및 내부 이벤트 반영 코드 추가 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tAnalyticsLog, BBLogManager 추가 - Tuist TuistScript+Templates dsym Upload를 하기 위한 Script 파일 추가 - 각 ViewController에 Analytics Event log 메서드 추가 - Crashlytics Log Method 추가
…into feat/#723-add-firebase-crashlytics-module
akrudal
previously approved these changes
Dec 20, 2024
| @@ -29,9 +29,11 @@ final class CameraDisplayNavigator: CameraDisplayNavigatorProtocol { | |||
| func showErrorAlert() { | |||
| let confirmHandler: BBAlertActionHandler = { [weak self] alert in | |||
| self?.toCamera() | |||
| BBLogManager.analytics(logType: BBEventAnalyticsLog.clickCameraButton(entry: .failedAlertConfirm)) | |||
There was a problem hiding this comment.
얘네는 analytics에 넣는 이유가 몬가요
There was a problem hiding this comment.
생각해 보니깐 에러 발생했는데 analytics로 이벤트 트래킹 처리할 필요는 없을 것 같네요 :)
| @@ -147,6 +152,7 @@ final class FamilyNameSettingViewController: BBNavigationViewController<FamilyNa | |||
|
|
|||
| groupConfirmButton.rx | |||
| .tap | |||
| .do { _ in BBLogManager.analytics(logType: BBEventAnalyticsLog.clickFamilyButton(entry: .familyNameSetting))} | |||
There was a problem hiding this comment.
얘네들 viewcontroller에서 do로 받아서 처리하는 것보다 뷰모델에 넣는게 낫지 않을까여?🫨
| @@ -44,6 +44,7 @@ public final class PrivacyViewController: BaseViewController<PrivacyViewReactor> | |||
| //MARK: Configure | |||
| public override func setupUI() { | |||
| super.setupUI() | |||
| BBLogManager.analytics(logType: BBEventAnalyticsLog.viewPage(pageName: .setting)) | |||
There was a problem hiding this comment.
이거는 왜 뷰디드로드에 안넣구...?!여기에 잇져?!
There was a problem hiding this comment.
오우 쉿 테스트 용으로 한거 안지웠나봐용
akrudal
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔵PR을 올리기 전 아래 사항을 확인해주세요.
(위 내용은 지워주세요)
😽 Firebase Crashlytics를 사용해서 Error 로깅 작업 해요
BBCrashErrorType 추가BBEventAnalyticsLogEnum Type 추가BBLogManagerEnum Type 추가 및 내부 로그 이벤트 메서드 추가TargetScript+Template추가 및 Firebase script 정의🛠️ Firebase Crashlytics dsym 업로드
해당 경로에 있는 run을 실행하도록 하여 dsym 파일을 자동으로 업로드 하도록 하였습니다.
Firebase Analytics 로그 이벤트 추가
🟡차후 계획 (Crash Error 발생하는 코드에 코드 넣어주세요)
BBLogManger코드를 넣어 에러 확인 할 수 있도록 해주세요 Are you Okay?✅테스트 케이스
🙏🏻아래와 같이 PR을 리뷰해주세요.