chore: 코드리뷰 반영

depromeet · Jul 14, 2024 · 16d71cc · 16d71cc
1 parent 815f7da
commit 16d71cc
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 11 deletions.
diff --git a/apps/web/app/layout.tsx b/apps/web/app/layout.tsx
@@ -1,4 +1,4 @@
-import { QueryClientProvider } from '@sambad/web-domains/commmon';
+import { Providers } from '@sambad/web-domains/commmon';
 import { Inter } from 'next/font/google';
 
 import type { Metadata } from 'next';
@@ -20,7 +20,7 @@ export default function RootLayout({
   return (
     <html lang="en">
       <body className={inter.className}>
-        <QueryClientProvider>{children}</QueryClientProvider>
+        <Providers>{children}</Providers>
       </body>
     </html>
   );

diff --git a/packages/core/eslint-config/base.js b/packages/core/eslint-config/base.js
@@ -37,7 +37,8 @@ module.exports = {
       },
     ],
     'no-duplicate-imports': 'error',
-    'no-unused-vars': ['error', { varsIgnorePattern: '^_', argsIgnorePattern: '^_' }],
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': 'error',
     'react/jsx-curly-brace-presence': ['error', { props: 'never', children: 'never' }],
 
     'react/no-unknown-property': ['error', { ignore: ['css'] }],

diff --git a/packages/web-domains/package.json b/packages/web-domains/package.json
@@ -13,8 +13,7 @@
   },
   "dependencies": {
     "@tanstack/react-query": "^5.50.1",
-    "axios": "^1.7.2",
-    "qs": "^6.12.3"
+    "axios": "^1.7.2"
   },
   "devDependencies": {
     "@sambad/sds": "workspace:*",

diff --git a/packages/web-domains/src/common/contexts/Providers.tsx b/packages/web-domains/src/common/contexts/Providers.tsx
@@ -0,0 +1,9 @@
+'use client';
+
+import { PropsWithChildren } from 'react';
+
+import { QueryClientProvider } from './QueryClientProvider';
+
+export const Providers = ({ children }: PropsWithChildren) => {
+  return <QueryClientProvider>{children}</QueryClientProvider>;
+};
diff --git a/packages/web-domains/src/common/contexts/QueryClientProvider.tsx b/packages/web-domains/src/common/contexts/QueryClientProvider.tsx
@@ -1,7 +1,6 @@
 'use client';
 import { isServer, QueryClient, QueryClientProvider as TanstackProvider } from '@tanstack/react-query';
-
-import type { PropsWithChildren } from 'react';
+import { PropsWithChildren } from 'react';
 
 const makeQueryClient = () => {
   return new QueryClient({

diff --git a/packages/web-domains/src/common/index.ts b/packages/web-domains/src/common/index.ts
@@ -1 +1,2 @@
 export { QueryClientProvider } from './contexts/QueryClientProvider';
+export { Providers } from './contexts/Providers';
diff --git a/...web-domains/src/first-domain/features/services/useFirstFeatureOfFirstDomainTestService.ts b/...web-domains/src/first-domain/features/services/useFirstFeatureOfFirstDomainTestService.ts
@@ -1,14 +1,11 @@
-import { useEffect, useState } from 'react';
+import { useState } from 'react';
 
 import { useHealthCheckQuery } from '../../../common/apis/queries/useHealthCheckQuery';
 
 export const useFirstFeatureOfFirstDomainService = () => {
   const [displayText, setDisplayText] = useState<string>('');
 
   const { data } = useHealthCheckQuery();
-  useEffect(() => {
-    console.log(data);
-  }, [data]);
 
   const handleChangeDisplayText = () => {
     setDisplayText('Test Container Button Clicked');
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		export { QueryClientProvider } from './contexts/QueryClientProvider';
		export { Providers } from './contexts/Providers';