fix(web-domains): 자기소개 정보 중 optional 데이터 대응 (#163)

* fix: 스키마 수정 및 널러블 필터 수정 * fix: 빈 문자열도 잡도록 추가
depromeet · Aug 27, 2024 · 8ef90f2 · 8ef90f2
1 parent 930229c
commit 8ef90f2
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/packages/web-domains/src/about-me/common/apis/schema/MeetingMemberResponse.ts b/packages/web-domains/src/about-me/common/apis/schema/MeetingMemberResponse.ts
@@ -7,7 +7,7 @@ export interface MeetingMemberResponse {
   birth: string;
   job: string;
   location: string;
-  hobbies: Array<string>;
-  mbti: string;
-  introduction: string;
+  hobbies?: Array<string>;
+  mbti?: string;
+  introduction?: string;
 }
diff --git a/packages/web-domains/src/about-me/features/components/Profile/Profile.tsx b/packages/web-domains/src/about-me/features/components/Profile/Profile.tsx
@@ -27,7 +27,7 @@ export const Profile = (props: ProfileProps) => {
   const age = birthFromProps && generateAge(birthFromProps);
   const gender = generateGender(genderFromProps);
 
-  const infoBadges = [age, gender, mbti, location, job].filter(Boolean);
+  const infoBadges = [age, gender, mbti, location, job].filter((value) => value != null);
 
   return (
     <Fragment>

diff --git a/packages/web-domains/src/about-me/features/containers/AboutMeContainer.tsx b/packages/web-domains/src/about-me/features/containers/AboutMeContainer.tsx
@@ -10,7 +10,7 @@ import { useGetMemberByParams } from '../hooks/useGetMemberByParams';
 export const AboutMeContainer = () => {
   const { data } = useGetMemberByParams();
 
-  const hasNoInfo = !data?.hobbies.length && !data?.introduction.length;
+  const hasNoInfo = data?.hobbies == null && (data?.introduction == null || data?.introduction === '');
 
   if (hasNoInfo) return <EmptyView title="아직 입력한 정보가 없어요" style={{ height: '300px' }} />;
 

diff --git a/packages/web-domains/src/home/features/my-profile/components/AboutMe.tsx b/packages/web-domains/src/home/features/my-profile/components/AboutMe.tsx
@@ -9,7 +9,7 @@ interface AboutMeProps {
 }
 
 export const AboutMe = ({ info }: AboutMeProps) => {
-  const hasNoInfo = !info?.hobbies.length && !info?.introduction;
+  const hasNoInfo = info?.hobbies == null && (info?.introduction == null || info?.introduction === '');
 
   if (hasNoInfo) return <EmptyView title="아직 입력한 정보가 없어요" style={{ height: '300px' }} />;