chore: 순환참조 및 jsx bracket 해제 옵션 지정

depromeet · Jun 22, 2024 · d526183 · d526183
1 parent a9aa597
commit d526183
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 2 deletions.
diff --git a/packages/core/eslint-config/library.js b/packages/core/eslint-config/library.js
@@ -34,6 +34,14 @@ module.exports = {
       },
     ],
     'no-unused-vars': ['warn', { varsIgnorePattern: '^_', argsIgnorePattern: '^_' }],
+    'react/jsx-curly-brace-presence': ['warn', { props: 'never', children: 'never' }],
+    'import/no-cycle': [
+      'warn',
+      {
+        maxDepth: Infinity,
+        ignoreExternal: true,
+      },
+    ],
     '@typescript-eslint/consistent-type-imports': 'warn',
   },
   overrides: [

diff --git a/packages/core/eslint-config/next.js b/packages/core/eslint-config/next.js
@@ -4,7 +4,13 @@ const project = resolve(process.cwd(), 'tsconfig.json');
 
 /** @type {import("eslint").Linter.Config} */
 module.exports = {
-  extends: ['eslint:recommended', 'prettier', require.resolve('@vercel/style-guide/eslint/next'), 'turbo'],
+  extends: [
+    'eslint:recommended',
+    'plugin:react/recommended',
+    'prettier',
+    require.resolve('@vercel/style-guide/eslint/next'),
+    'turbo',
+  ],
   plugins: ['@typescript-eslint', 'only-warn', 'import'],
   globals: {
     React: true,
@@ -35,10 +41,11 @@ module.exports = {
       },
     ],
     'no-unused-vars': ['warn', { varsIgnorePattern: '^_', argsIgnorePattern: '^_' }],
+    'react/jsx-curly-brace-presence': ['warn', { props: 'never', children: 'never' }],
     'import/no-cycle': [
       'warn',
       {
-        maxDepth: 1,
+        maxDepth: Infinity,
         ignoreExternal: true,
       },
     ],

diff --git a/packages/core/eslint-config/package.json b/packages/core/eslint-config/package.json
@@ -15,6 +15,7 @@
     "eslint-config-turbo": "^2.0.0",
     "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-only-warn": "^1.1.0",
+    "eslint-plugin-react": "^7.34.3",
     "typescript": "^5.3.3"
   }
 }
diff --git a/packages/core/eslint-config/react-internal.js b/packages/core/eslint-config/react-internal.js
@@ -34,6 +34,14 @@ module.exports = {
       },
     ],
     'no-unused-vars': ['warn', { varsIgnorePattern: '^_', argsIgnorePattern: '^_' }],
+    'react/jsx-curly-brace-presence': ['warn', { props: 'never', children: 'never' }],
+    'import/no-cycle': [
+      'warn',
+      {
+        maxDepth: Infinity,
+        ignoreExternal: true,
+      },
+    ],
     '@typescript-eslint/consistent-type-imports': 'warn',
   },
   overrides: [{ files: ['*.js?(x)', '*.ts?(x)'] }],

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml