Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sds): Skeleton.Paragraphs 누락된 ref 추가 및 타입 수정 #108

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

Andrevile
Copy link
Member

@Andrevile Andrevile commented Aug 18, 2024

🎉 변경 사항

스켈레톤 Paragraphs 에 ref가 누락되어있고, 타입이 중복으로 참조되어서 제거했습니다.

스크린샷 2024-08-18 오전 11 20 18

🔗 링크

🙏 여기는 꼭 봐주세요!

Copy link
Member

@Doeunnkimm Doeunnkimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sds 첫 기여를 축하드리며.. 🎉

packages/core/sds/src/components/Skeleton/Paragraphs.tsx Outdated Show resolved Hide resolved
@Doeunnkimm Doeunnkimm changed the title fix: add ref props parameter and remove duplicated reference type fix(sds): Skeleton.Paragraphs 누락된 ref 추가 및 타입 수정 Aug 18, 2024
Copy link
Collaborator

@semnil5202 semnil5202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스켈레톤 아주 좋아~~~ 도은넴 리뷰 사항 변경되면 바로 머지 가시죵~ 미리 어프로브 해둘꼐여

@Andrevile Andrevile requested a review from Doeunnkimm August 19, 2024 14:03
@Andrevile Andrevile merged commit 76dfa36 into main Aug 19, 2024
2 checks passed
@Andrevile Andrevile deleted the fix/skeleton branch August 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants