fix(web-domains): about 페이지에서 answers 리스트 중 comment가 없을 경우 렌더링하지 않도록 수정 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doeunnkimm
requested review from
semnil5202,
LeeJeongHooo,
Andrevile and
sambad-adventure
as code owners
Andrevile
reviewed
Aug 19, 2024
| @@ -30,7 +30,7 @@ export const AnsweredQuestionsContainer = () => { | |||
| <Accordion.Content> | |||
| <div css={answerContentCss}> | |||
| <Txt typography="heading3">{answer.content}</Txt> | |||
| <Txt typography="body2">{answer.commentContent}</Txt> | |||
| {answer.commentContent != null && <Txt typography="body2">{answer.commentContent}</Txt>} | |||
There was a problem hiding this comment.
null은 string이나 Number처럼 형변환이 안될거같아서 상관없을거 같긴한데,
체크차원에서 여쭤보자면 !==이 아니라 !=은 의도하신 코드이신거죠?
There was a problem hiding this comment.
넹 의도했어요. nullish한 것만 거르고 싶었습니다~!
Andrevile
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
제곧내..
🔗 링크
QA
🙏 여기는 꼭 봐주세요!