Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sds): Button loading 스펙 추가 #130

Merged
merged 4 commits into from
Aug 26, 2024
Merged

feat(sds): Button loading 스펙 추가 #130

merged 4 commits into from
Aug 26, 2024

Conversation

semnil5202
Copy link
Collaborator

🎉 변경 사항

Aug-24-2024 15-24-13

🔗 링크

🙏 여기는 꼭 봐주세요!

@Doeunnkimm Doeunnkimm changed the title refactor(sds): Button Loading 기능 추가 feat(sds): Button Loading 기능 추가 Aug 24, 2024
Copy link
Member

@Doeunnkimm Doeunnkimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spinner 따로 빼지면 그때 다시 Spinner 자체에도 리뷰 남겨보겟습니다 🙇🏻‍♀️

packages/core/sds/src/components/Button/Button.tsx Outdated Show resolved Hide resolved
packages/core/sds/src/components/Button/Button.tsx Outdated Show resolved Hide resolved
packages/core/sds/src/components/Button/Button.tsx Outdated Show resolved Hide resolved
@Doeunnkimm Doeunnkimm changed the title feat(sds): Button Loading 기능 추가 feat(sds): Button loading 스펙 추가 Aug 24, 2024
@semnil5202 semnil5202 requested a review from Doeunnkimm August 24, 2024 17:28
@semnil5202 semnil5202 merged commit a061ed5 into main Aug 26, 2024
2 checks passed
@semnil5202 semnil5202 deleted the feat/SAMBAD-282 branch August 26, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants