refactor(web-domains): Profile Image -> Avatar로 일괄 변경 및 objectFit: cover 적용 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semnil5202
requested review from
Doeunnkimm,
LeeJeongHooo,
Andrevile and
sambad-adventure
as code owners
Doeunnkimm
reviewed
Aug 26, 2024
| @@ -16,5 +16,5 @@ export const Avatar = ({ imageUrl, alt = 'profile-image', size, Icon, ...rest }: | |||
| ); | |||
| } | |||
|
|
|||
| return <Image src={imageUrl} alt={alt} {...rest} />; | |||
| return <Image src={imageUrl} alt={alt} css={{ objectFit: 'cover' }} {...rest} />; | |||
There was a problem hiding this comment.
음.. style 태그 사용해도 되었을 거 같긴 한데 요거 한번더 수정해주실 수 있나요?
Doeunnkimm
reviewed
Aug 26, 2024
| @@ -3,8 +3,8 @@ import { borderRadiusVariants, colors } from '@sambad/sds/theme'; | |||
| import dayjs from 'dayjs'; | |||
| import Link from 'next/link'; | |||
|
|
|||
| import { Avatar } from '../../../../../common/components/Avatar/Avatar'; | |||
There was a problem hiding this comment.
요건 나중에 일괄 변경하시죠 ㅠ 이런게 한 둘이 아니라서,,,,
There was a problem hiding this comment.
흠 이거 급한 건 아니였던 거 같은데 쌓여만 가는군요 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
🔗 링크
🙏 여기는 꼭 봐주세요!