[feat][#93] 온보딩 상태 관련 api 구현 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sejoon00
reviewed
Aug 30, 2024
| @AuthUser User user | ||
| ) { | ||
| return ResponseEntity.ok(userService.getUserOnboardStatus(user)); | ||
| } |
There was a problem hiding this comment.
이렇게 상태 조회 api를 만드는 것보다 login시에 온보딩 상태도 같이 보내주고, userController에 있는 GET /me api에 유저 상태 정보를 주는걸 추가하는거 어떻게 생각해용?
There was a problem hiding this comment.
로그인 결과값으로만 온보딩 여부를 주면, 온보딩 하다가 나갔다가 다시 들어왔을 때 온보딩 상태 여부를 모를 것 같아서 온보딩상태조회 api를 따로 만들었어요!
GET /me api에 유저 상태 정보를 주는걸 추가가 혹시 뭘 의미하는걸까요?? 아직은 안쓰고 있는 api인데 여기 온보딩 상태만 내려주는걸로 바꾸는거러 제안하신건가용?
JeongSangByuk
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타