-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨마이페이지 음악 리스트 필터링 기능 추가 #301
Open
thoonk
wants to merge
24
commits into
develop
Choose a base branch
from
feature/mypage-filtering
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 UITableView DataSource 에서 Diffable DataSource 로 변경 작업 - 기존 2개(드랍, 좋아요)의 UITableView(Hidden 처리)를 1개의 UICollectionView를 이용한 개선 작업 - Compositional Layout 적용 - 콘텐츠 수에 따른 CollectionView Height 업데이트를 통한 전체 스크롤뷰 높이 조정
- 마이페이지 진입 시 Height 값과 이후 다른 탭(좋아요) 선택 후 Height 값(정상)이 달라 section 값 전달되고 선 호출 처리를 통해 임시 해결
…ew로 변경 작업 처리 - 기존 Diffable DataSource 로직 변경 없음 - Compositional Layout 제거
- TabBarView UI 구현 및 바인딩 처리 - 기존 TabListView 보일러플레이트 코드 개선
- 기존 OptionModalView 재사용
- API 검토 후 기존 MusicListTableView HeaderView 제거 예정
- 원인: cell contentView 서브뷰 여백 설정으로 인해 contentView 높이를 44로 고정하려 함. - 해결: lessThanEqualTo를 사용하여, 동적 크기가 허용시킴.
- sticky에서 탭리스트 변경 시 기존 탭리스트 UI 업데이트 처리되지 않는 이슈 처리
- 스티키 탭 아래 여백 수정 - timeAgoLabel 디폴트 텍스트 수정 - 옵션모달뷰 배경 Dimmed 알파값 수정
- 좋아요 이미지 추가 및 컬러값 변경 - 백엔드 개발 반영 후 작업 예정
- scrollView offset 값 변경
- 백엔드 작업 후 좋아요한 뮤직 노출 처리 필요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 배경
close #296
내용
스크린샷 (optional)