Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linter service port check for native sidecars #355

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

eminugurkenar
Copy link
Contributor

currently does not consider native sidecars , and complains about target port not exist

[POP-1106] No target ports match service port

@eminugurkenar eminugurkenar force-pushed the master branch 2 times, most recently from e9e05d0 to b90f4ab Compare October 22, 2024 07:13
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eminugurkenar Nice catch! Thank you for this update.

@derailed derailed merged commit 7cb3375 into derailed:master Nov 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants