Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Linux] Compile libsocket for Linux in github action ci. #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CI][Linux] Compile libsocket for Linux in github action ci. #77

wants to merge 1 commit into from

Conversation

talregev
Copy link

@talregev talregev commented Sep 3, 2021

Compile libsocket for Linux, macOS and Windows in github action ci.

@talregev talregev force-pushed the TalR/compile_github_action_ci branch 4 times, most recently from 1871953 to 3dfcd88 Compare September 3, 2021 06:13
@dermesser
Copy link
Owner

not sure about macOS and windows - libsocket is not intended to run there. Maybe macOS works with the FreeBSD configuration though

@talregev talregev force-pushed the TalR/compile_github_action_ci branch from 3dfcd88 to 9c18fe0 Compare September 3, 2021 06:18
@talregev
Copy link
Author

talregev commented Sep 3, 2021

It not cross platform? I though it is. Sorry.

@dermesser
Copy link
Owner

it is cross platform. Across Linux, FreeBSD, OpenBSD with some restrictions, and Solaris ;-)

@talregev
Copy link
Author

talregev commented Sep 3, 2021

I will convert the ci for linux only. (ubuntu). then maybe other people can continue to dev it to mac and windows.
Also I will close the vcpkg request. it will be relevant if libsocket will support windows.
Can it be added as a feature request that libsocket will support windows and mac?

@dermesser
Copy link
Owner

feature request no, pull request yes :)

@talregev talregev force-pushed the TalR/compile_github_action_ci branch from 9c18fe0 to f33e709 Compare September 3, 2021 06:25
@talregev talregev changed the title [CI] Compile libsocket for Linux, macOS and Windows in github action ci. [CI][Linux] Compile libsocket for Linux in github action ci. Sep 3, 2021
@talregev
Copy link
Author

talregev commented Sep 3, 2021

Please review here with my CI:
talregev#1

only ubuntu. more will follow. You can also upload artifacts. also maybe add static and share configuration.

@talregev
Copy link
Author

talregev commented Sep 3, 2021

Did you disable github action ci on your repo?

@talregev talregev force-pushed the TalR/compile_github_action_ci branch from f33e709 to 4b1a2f1 Compare September 3, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talregev @dermesser