Update mink-selenium2-driver to valid version #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davereid looking close! Let me know if you want to 🦆 this. |
|
I think the hope is that minkphp/MinkSelenium2Driver#313 resolves this by just providing a backwards compatible 1.3.x-dev version that can be just used without needing to update any version requirements and fixes all builds. In that case this wouldn't be necessary at all. |
|
This has been resolved separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
https://www.drupal.org/project/drupal/issues/3078671
minkphp/MinkSelenium2Driver#313
drupal-composer/drupal-project#511
webflo/drupal-core-require-dev#14
Alternatively we hope that this is fixed upstream today with a new 1.3.x version provided by MinkSelenium2Driver that would fulfill the requirements.