[Azure] Support Realtime API #7
Conversation
| deployment: deploymentName, | ||
| }); | ||
| const rt = new AzureOpenAIRealtimeWebSocket(client); | ||
| await rt.open(); |
There was a problem hiding this comment.
if we're doing our own Azure class, do we still need the open() method? Wondering if we can, if we should decrease the delta between OAI and AOAI as much as possible
There was a problem hiding this comment.
Yes, we need to to wait for fetching a token before we open the socket and this is not possible inside a class constructor.
| } | ||
| return url; | ||
| } | ||
| const deploymentName = this.client.deploymentName ?? this.options.deploymentName; |
There was a problem hiding this comment.
quick check - if deployment name is set at the client, won't that add /deployments/deployment_name to the path? I wasn't able to support the scenario of a deployment name being passed at the client-level in Python so curious if there is something different here that lets JS do it.
There was a problem hiding this comment.
if deployment name is set at the client, won't that add /deployments/deployment_name to the path?
Yes, the request path, not the baseURL one.
There was a problem hiding this comment.
Oh right, now I remember that deployment name gets added to the base URL in buildRequest for JS and not in the client init (like Python). Cool, disregard this comment
deyaaeldeen
force-pushed
the
feat/azure-rt-internal
branch
from
31d3db3 to
c3cc69c
Compare
Support Azure Realtime API
In order to do so, this PR adds new
AzureOpenAIRealtimeWebSocketandAzureOpenAIRealtimeWSclientsKey Changes
1. Introduce New
openMethodopenmethod enables asynchronous fetching of the Azure AD token and establishes the WebSocket connection afterward.2. New
getAzureADTokenMethod inAzureOpenAIgetAzureADTokenmethod in theAzureOpenAIclass to provide refreshed Azure AD tokens.