Improve error around the repo_name argument in support_panel() #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thought I had is whether we should rename the argument from repo_name to repo_url to help make it clearer. Though wary of how much this might be a breaking change anyone who has adopted it - @rmbielby, what do you think? |
jen-machin
reviewed
Feb 20, 2024
It's not used too widely so far, so we could probably fairly easily go round and do the updates. And it'll give a pretty clear error when it does break. |
|
Just added some fixes to the links as they were all broken from us trying to meet line-length constraints! |
rmbielby
approved these changes
Feb 22, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it more explicit in the documentation and error message why the repo_name field is erroring.