Update dashboard_deploy_template.yaml #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
If statement failed in deploy script, looks like it just returned a false due to the syntax used:
[[: main: unexpected operatorThe result was that the condition was always false and so a dashboard always deployed to dev-* instead of the live dashboard.
Did a bit of digging and it looks like this is just the limited functionality of
shversusbash, so I've set the faulty bit of the pipeline to run inbash. I've tested this out on the attendance dashboard and it sets the deploy target successfully.Attendance dashboard deploy triggered from main:
https://github.com/dfe-analytical-services/attendance-data-dashboard/actions/runs/12928294233/job/36057454809
Attendance dashboard deploy triggered from other branch:
https://github.com/dfe-analytical-services/attendance-data-dashboard/actions/runs/12928068789/job/36057911578