EES-5544 Change data set import page accordions into a table #5459
Conversation
bennettstuart
force-pushed
the
EES-5544
branch
from
369e1a3 to
c1cb095
Compare
bennettstuart
force-pushed
the
EES-5544
branch
from
602e242 to
85840e2
Compare
bennettstuart
force-pushed
the
EES-5544
branch
2 times, most recently
from
9a80962 to
3024245
Compare
...lore-education-statistics-admin/src/pages/release/data/components/DataFilesTable.module.scss
Outdated
Show resolved
Hide resolved
...lore-education-statistics-admin/src/pages/release/data/components/DataFilesTable.module.scss
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/release/data/components/DataFilesTable.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/release/data/components/DataFilesTable.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/pages/release/data/components/DataFilesTable.tsx
Show resolved
Hide resolved
...e-education-statistics-admin/src/pages/release/data/components/ReleaseDataUploadsSection.tsx
Outdated
Show resolved
Hide resolved
| @@ -23,9 +23,10 @@ user checks table row heading contains | |||
| user waits until element contains xpath://table/tbody/tr[${row}]/th[${column}] ${expected} | |||
|
|
|||
| user checks table cell contains | |||
| [Arguments] ${row} ${column} ${expected} ${parent}=css:table | |||
| [Arguments] ${row} ${column} ${expected} ${parent}=css:table ${wait}=%{WAIT_SMALL} | |||
There was a problem hiding this comment.
Does this need a wait? Typically, we could use some other keyword to check that the table (or something in it) has rendered before checking the table cells.
Most 'check' keywords don't include waits for this reason, so this is fairly inconsistent.
There was a problem hiding this comment.
Was added due to table updating asynchronously to the form submit, but have abstracted the waits into separate keywords
bennettstuart
force-pushed
the
EES-5544
branch
from
43985c4 to
d27e7c7
Compare
|
|
||
| a, | ||
| button { | ||
| margin-bottom: 1rem; |
There was a problem hiding this comment.
Seems like the spacing is a bit excessive now:
Additionally, we should be using govuk-spacing function for this.
1 spacing unit:
2 spacing units:
Feels like 1 spacing unit might actually be fine
| <th scope="col">Size</th> | ||
| <th scope="col">Status</th> | ||
| <th scope="col">Actions</th> |
There was a problem hiding this comment.
Seems like we're missing a bunch of columns that appear in the ticket and acceptance criteria? Is this on purpose? If so, the ticket needs to be updated to describe precisely what is needed.
If not, looks like we need to add those in. We'll need to update the tests accordingly as well!
There was a problem hiding this comment.
With the addition of the "View details" modal, we've opted to remove some columns to make the rows more concise at first glance wit the added option to see more information. Cam and I have discussed briefly here in the ticket comments in which I showed example:
And he responded:
For the columns to show, I think I’d drop the uploaded by, and make the status wrap for data replacement in progress so that it’s over two lines, I think both of those together should give enough space for longer subject titles?
Leaving just:
- Title, Size, Status and Actions
See Ticket EES-5544