Skip to content

Commit

Permalink
Merge branch 'main' into spofford/rsq
Browse files Browse the repository at this point in the history
  • Loading branch information
adamspofford-dfinity authored Nov 3, 2023
2 parents 6294c67 + a225a4a commit 37fcfc1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Types passed to the `to_request_id` function can now contain nested structs, signed integers, and externally tagged enums.
* `Envelope` struct is public also outside of the crate.
* Remove non-optional `ic_api_version` field (whose value is not meaningfully populated by the replica) and optional `impl_source` and `impl_revision` fields (that are not populated by the replica) from the expected `/api/v2/status` endpoint response.
* Drop `senders` field from user delegations (type `Delegation`).

## [0.29.0] - 2023-09-29

Expand Down
3 changes: 0 additions & 3 deletions ic-transport-types/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,6 @@ pub struct Delegation {
/// If present, this delegation only applies to requests sent to one of these canisters.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub targets: Option<Vec<Principal>>,
/// If present, this delegation only applies to requests originating from one of these principals.
#[serde(default, skip_serializing_if = "Option::is_none")]
pub senders: Option<Vec<Principal>>,
}

const IC_REQUEST_DELEGATION_DOMAIN_SEPARATOR: &[u8] = b"\x1Aic-request-auth-delegation";
Expand Down
1 change: 0 additions & 1 deletion ref-tests/tests/integration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,6 @@ mod identity {
expiration: i64::MAX as u64,
pubkey: signing_identity.public_key().unwrap(),
targets: None,
senders: None,
};
let signature = sending_identity.sign_delegation(&delegation).unwrap();
let delegated_identity = DelegatedIdentity::new(
Expand Down

0 comments on commit 37fcfc1

Please sign in to comment.