Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hyper-transport url #488

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: hyper-transport url #488

merged 2 commits into from
Nov 15, 2023

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Nov 13, 2023 •
edited
Loading

Description

Hyper transport produced a url with a double slash, namely: /api/v2//canister/5v3p4-iyaaa-aaaaa-qaaaa-cai/query

How Has This Been Tested?

It seems hyper transport is not tested e2e.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@nikolay-komarevskiy nikolay-komarevskiy changed the title fix hyper-transport url fix: hyper-transport url Nov 13, 2023
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review November 13, 2023 17:36
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner November 13, 2023 17:36
@krpeacock krpeacock merged commit 081af29 into dfinity:main Nov 15, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamspofford-dfinity adamspofford-dfinity adamspofford-dfinity approved these changes

@krpeacock krpeacock krpeacock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikolay-komarevskiy @krpeacock @adamspofford-dfinity