feat: allow to override provider url upon installation #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
reviewed
Dec 20, 2024
|
Overall LGTM! Just have one or two minor comments/suggestions. |
ninegua
previously approved these changes
Jan 6, 2025
gregorydemay
commented
Jan 8, 2025
There was a problem hiding this comment.
Thanks @lpahlavi for the feedback! Should be ready for a 2nd round.
lpahlavi
previously approved these changes
Jan 9, 2025
# Conflicts: # .github/workflows/ci.yml
lpahlavi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to override the URL that will be queried by the EVM RPC canister via a regex specified upon canister installation. This is allows testing against a local Ethereum development setup (such as foundry) without changing the client calling the EVM RPC canister.